search

liusida / ComfyUI-Login

A custom node that implements basic login for ComfyUI
MIT License
92 stars 12 forks source link

Potential confliction with `ComfyUI_frontend` #15

Closed liusida closed 4 months ago

liusida commented 4 months ago

Hey future me, we blocked all unauthorized access to ComfyUI before Login, but another UI, e.g. ComfyUI_frontend might not have the Login page, so how can they login??

liusida commented 4 months ago

Hint: to access the protected ComfyUI, we might need to use this:

const newPath = path.replace(/^\/api/, '') + (path.includes('?') ? '&' : '?') + 'token=$2...';

liusida commented 4 months ago

But let's first see how ComfyUI_frontend supports other extensions like Manager. :)

liusida commented 4 months ago

after https://github.com/liusida/ComfyUI-Login/commit/5f3e36699a9630bec464462377ae26d764ab1c83 Now ComfyUI_forntend will redirect the user to its login page. Nice.

But they don't have a password field, the user can only enter username. xD Not solved yet.

liusida commented 4 months ago

If they merge ComfyUI_frontend to ComfyUI, and replace web with it, there'll be no confliction.