liusong1111 / synapse-extension

MIT License
0 stars 0 forks source link

[ui] useEffect depends are wrong #21

Open liusong1111 opened 4 years ago

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/a12c8def62a5d1c247b35b79b0d05f3d4c5b4859/src/ui/Components/AddressList/index.tsx#L34

should depends on []


useEffect depends refs:

https://overreacted.io/zh-hans/a-complete-guide-to-useeffect/

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/a3d0f9000349850885baeecaa8582f486b75a1fd/src/ui/Components/AddressListItem/index.tsx#L69

should depends on [lock]

https://github.com/rebase-network/synapse-extension/blob/a3d0f9000349850885baeecaa8582f486b75a1fd/src/ui/Components/AddressListItem/index.tsx#L83

[address]

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/bb8fc827adca2ab2281480dd068858d1882ccbf4/src/ui/pages/Address/index.tsx#L241

[]

syuukawa commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/a12c8def62a5d1c247b35b79b0d05f3d4c5b4859/src/ui/Components/AddressList/index.tsx#L34

should depends on []

useEffect depends refs:

https://overreacted.io/zh-hans/a-complete-guide-to-useeffect/

https://github.com/rebase-network/synapse-extension/commit/833b13cc40377813247b24a9a5d066089a941a09#diff-6142113e934bc47305f95bb741a54d8e

syuukawa commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/a3d0f9000349850885baeecaa8582f486b75a1fd/src/ui/Components/AddressListItem/index.tsx#L69

should depends on [lock]

https://github.com/rebase-network/synapse-extension/blob/a3d0f9000349850885baeecaa8582f486b75a1fd/src/ui/Components/AddressListItem/index.tsx#L83

[address]

https://github.com/rebase-network/synapse-extension/commit/833b13cc40377813247b24a9a5d066089a941a09#diff-6142113e934bc47305f95bb741a54d8e

syuukawa commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/bb8fc827adca2ab2281480dd068858d1882ccbf4/src/ui/pages/Address/index.tsx#L241

[]

https://github.com/rebase-network/synapse-extension/commit/833b13cc40377813247b24a9a5d066089a941a09#diff-6142113e934bc47305f95bb741a54d8e