search

liusong1111 / synapse-extension

MIT License
0 stars 0 forks source link

[typo or naming] #5

Open liusong1111 opened 4 years ago

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/af0985a81b5a6d578b3605bb459b4487283ffab4/src/background/index.ts#L57

isValidMnemonic MESSAGE_TYPE.IS_NOT_VALIDATE_MNEMONIC => IS_INVALID_XXX

https://github.com/rebase-network/synapse-extension/blob/af0985a81b5a6d578b3605bb459b4487283ffab4/src/common/locales/zh.ts#L47-L48

invalidated => invalid

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/af0985a81b5a6d578b3605bb459b4487283ffab4/src/wallet/keychain.ts#L44

'Bitcoin seed' => a little wired

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/f528957618b7a2fb8c63a39de05c35b9618e6a1a/src/utils/constants.ts#L76

https://github.com/rebase-network/synapse-extension/blob/f528957618b7a2fb8c63a39de05c35b9618e6a1a/src/utils/constants.ts#L91

duplicated and unclear

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/af0985a81b5a6d578b3605bb459b4487283ffab4/src/utils/apis.ts#L29

Unspent => Live

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/af0985a81b5a6d578b3605bb459b4487283ffab4/src/utils/apis.ts#L54

console.log(/result error/, JSON.stringify(result));
liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/a3d0f9000349850885baeecaa8582f486b75a1fd/src/ui/Components/AddressListItem/index.tsx#L40

TAddressInfo => AddressInfo

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/a12c8def62a5d1c247b35b79b0d05f3d4c5b4859/src/ui/Components/TokenListItem/index.tsx#L26

TTokenInfo => TokenInfo

liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/bb8fc827adca2ab2281480dd068858d1882ccbf4/src/ui/pages/ExportMnemonic/index.tsx#L55

helperText={errors.password && touched.password && errors.password}
liusong1111 commented 4 years ago

https://github.com/rebase-network/synapse-extension/blob/bb8fc827adca2ab2281480dd068858d1882ccbf4/src/ui/pages/ExportMnemonic/index.tsx#L112

setVaildate(false);