liuweireign / dpkt

Automatically exported from code.google.com/p/dpkt
Other
0 stars 0 forks source link

vrrp.py has an initialization bug for the offset variable #87

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Input packet:
p = 
'\x01\x00\x5e\x00\x00\x12\x00\x00\x5e\x00\x01\x36\x81\x00\x0a\x6c\x08\x00\x45\x0
0\x00\x1c\xff\xa2\x00\x00\xff\x70\x2a\x29\xfd\xf4\xe6\x9c\xd2\xda\xda\x39\x00\x0
0\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x0
0'

2. Parse with dpkt.ethernet.Ethernet(p)

3. There is a parsing error:
File "/usr/local/lib/python2.7/dist-packages/dpkt/vrrp.py", line 37, in unpack
    self.auth = self.data[off+4:]

The fix is to initialize off to 0 before the for loop. I attached the patch 
that fixes that. Anyone sees any problems with it?

Original issue reported on code.google.com by timur.al...@gmail.com on 19 Mar 2012 at 3:45

Attachments: