liuxinwust / test_robot

aubo robot meta-package. http://ros.org/wiki/aubo_robot
55 stars 27 forks source link

Fix #5 #6

Closed 130s closed 7 years ago

130s commented 7 years ago

Please see https://github.com/ros-planning/moveit/pull/247 for the change in the upstream package. Sorry for the inconvenience.

Also adding is a config file for Travis CI that utilizes industrial_ci.

130s commented 7 years ago

Now running a prerelease test locally on my computer for confirmation.

130s commented 7 years ago

Prerelease test failed. Looks like unrelated to the issue raised in #5, and similar/the same to #4.

Test unfinished though, because the issue in #4 is worked around https://github.com/auboliuxin/aubo_robot/issues/4#issuecomment-263762203, we may want to merge this and make a new release to see if #5 will be fixed or not.

$ mkdir /tmp/prerelease_aubo
$ cd /tmp/prerelease_aubo
$ generate_prerelease_script.py   https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml indigo default ubuntu trusty amd64   aubo_robot   --level 0 --custom-repo aubo_robot:git:https://github.com/130s/aubo_robot:fix/5   --output-dir ./
$ ./prerelease.sh 
:
-- Call enable_testing()
-- Using CATKIN_TEST_RESULTS_DIR: /tmp/catkin_workspace/build_isolated/aubo_control/test_results
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE  
-- Found gtest sources under '/usr/src/gtest': gtests will be built
-- Using Python nosetests: /usr/bin/nosetests-2.7
-- catkin 0.6.18
-- Using these message generators: gencpp;genlisp;genpy
--  CMAKE_MODULE_PATH  /tmp/catkin_workspace/src/aubo_robot/aubo_control/cmake
-- Could NOT find libpcan headers.
-- Could NOT find libpcan library.
-- Found CommAPI include dir: /tmp/catkin_workspace/src/aubo_robot/aubo_control/include/comm
-- Found CommAPI library: /tmp/catkin_workspace/src/aubo_robot/aubo_control/lib/lib64/libI5-CAN.so
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LIBPCAN_LIB
    linked by target "joint_control_pcan" in directory /tmp/catkin_workspace/src/aubo_robot/aubo_control/src/joint_control_pcan

-- Configuring incomplete, errors occurred!
See also "/tmp/catkin_workspace/build_isolated/aubo_control/CMakeFiles/CMakeOutput.log".
See also "/tmp/catkin_workspace/build_isolated/aubo_control/CMakeFiles/CMakeError.log".
<== Failed to process package 'aubo_control': 
  Command '['/tmp/catkin_workspace/install_isolated/env.sh', 'cmake', '/tmp/catkin_workspace/src/aubo_robot/aubo_control', '-DCATKIN_DEVEL_PREFIX=/tmp/catkin_workspace/devel_isolated/aubo_control', '-DCMAKE_INSTALL_PREFIX=/tmp/catkin_workspace/install_isolated', '-DCATKIN_SKIP_TESTING=1', '-G', 'Unix Makefiles']' returned non-zero exit status 1

Reproduce this error by running:
==> cd /tmp/catkin_workspace/build_isolated/aubo_control && /tmp/catkin_workspace/install_isolated/env.sh cmake /tmp/catkin_workspace/src/aubo_robot/aubo_control -DCATKIN_DEVEL_PREFIX=/tmp/catkin_workspace/devel_isolated/aubo_control -DCMAKE_INSTALL_PREFIX=/tmp/catkin_workspace/install_isolated -DCATKIN_SKIP_TESTING=1 -G 'Unix Makefiles'

Command failed, exiting.
# END SUBSECTION
130s commented 7 years ago

@auboliuxin Looks like you directly added a commit without opening a pull request https://github.com/auboliuxin/aubo_robot/commit/d8f7267a9cbce4f9717fe49a4b5776b8dd08e3f7. It's your repository so I'm generally fine how ever you add commits.

But because this time someone (me) already tried contributing to the same piece of code you changed, IMO generally it's nice to open a pull request / add comments to the existing pull request, instead of directly adding commits (this way no one gets to know the branch changed and the existing pull request quietly starts conflicting) :)

Sorry for the rant, but how does this look to you?

130s commented 7 years ago

This PR has been ignored, but #2 seems to be resolved by the repo owner's direct commit, and #5 is no longer an issue upstream.