Closed GoogleCodeExporter closed 8 years ago
I would add that thought the same thing when installing it, although I would be
in
favor of the more verbose "django_extensions". That would be sort of in line
what
everyone else seems to be using, and one can easily say:
import django_extensions as extensions
Original comment by elsdoer...@gmail.com
on 19 Jul 2008 at 9:53
I'm open to changing it but probably would go with django_extensions over
djext. I want v.oostveen to weigh in
on it though.
Original comment by mtr...@gmail.com
on 19 Jul 2008 at 10:56
mtrier: I Already had some comment drawn up earlier but decided not to post it
and
leave it simmering in my head for awhile first.
The first time i installed django-command-extensions i had exactly the same
thoughts
as elsdoerfer and jbalonso described. Now over time i don't mind that much
anymore :)
In style i am:
-1 on changing the name in anything substantially different from what it's now.
+0 on changing the name at all.
And if there's a consensus to change it:
+1 for django_extensions (indeed seems to most logical name to go with)
I would like to have a final decision and patch in SVN for this some time before
Django 1.0 is released. Until that time i think we can discuss this (and reach a
conclusion :) and possibly other changes that break or require user actions for
django-command-extensions.
As i think that with Django 1.0 things will change enough that the name change
of
django-command-extensions would be just one very minor change for people to
deal with
compared to some recent patches like nfa and the file upload handling :)
Original comment by v.oostv...@gmail.com
on 22 Jul 2008 at 12:02
I guess I should toss my last two-cents in: django_extensions sounds fine to me.
Original comment by jbalo...@gmail.com
on 22 Jul 2008 at 1:50
Alright I think we're in agreement that django_extensions is an improvement and
probably worth doing. I agree
with v.oostveen that we definitely want to do it sooner rather than later. So
go ahead and change it whenever
you feel the timing is right. And be prepared for the grumbling especially
since a lot of folks might be svn co at
the extensions point not further up the tree.
I apologize for introducing something so generic to begin with.
Original comment by mtr...@gmail.com
on 23 Jul 2008 at 1:40
Hmm, thinking about this I wonder if management_extensions, or
command_extensions would be better.
Thoughts? Does it matter? My only thinking is that it's really management or
command extensions more
specifically rather than django as a whole. But you could go either way on it.
Original comment by mtr...@gmail.com
on 23 Jul 2008 at 1:44
I originally considered suggesting django_command_extensions, but I guess even I
thought that might be overdoing it.
I would prefer "django" being part of the name, though it's obviously not that
big a
deal. But just for good measure, let me throw into the mix:
django-cextensions (might be confused with C, the language, though)
django-commands
Original comment by elsdoer...@gmail.com
on 23 Jul 2008 at 2:07
(Hmm... elsdoerfer replies before I finish typing, and he says some of the same
things... *snip*)
django_command_extensions is semantically what you are looking for, but it's
dreadfully long. django_extensions.commands is the most appropriate use of the
namespace, but there's no other use of django_extensions currently out there.
If
this project were ever to expand to things other than management extensions, it
could
retreat the management extensions into django_extensions.commands.
All other ramblings aside: I think django_commands is your best bet.
I take it you're addressing "go ahead and change it" to v.oostveen? I'm not
actually
a part of this project, though I'd happily join in (I have a vested interest in
the
project). It's not necessary, though: I'll submit a patch in a moment.
Original comment by jbalo...@gmail.com
on 23 Jul 2008 at 2:29
Ok, this is a two-part patch made with svn diff, since doing an svn diff with a
high-level directory rename will only look ridiculous.
svn mv extensions django_commands
cd django_commands
apply rename-1.diff # This fixes old references to extensions
cd ..
apply rename-2.diff # This touches up the setup.py file
p.s. I did a regression test to see if the setup.py file still DTRT, but I
noticed
that the sdist command does not properly catch the template files. The
setup.py is
also extremely hairy... I'll try submitting a patch for it in another ticket.
Original comment by jbalo...@gmail.com
on 23 Jul 2008 at 2:52
Attachments:
Personally i don't like django_commands.
I'd rather have django_extensions and drop the 'commands' part from the name.
Cause we can always include other useful things as part of django_extensions
then
only commands.
Original comment by v.oostv...@gmail.com
on 24 Jul 2008 at 6:20
Good point. Change it to django_extensions. :)
Original comment by mtr...@gmail.com
on 24 Jul 2008 at 6:22
I say change it provided everyone agrees. There that sounds less demanding. :)
But I think the point is a
good one. We might decide that certain context procesors or template tags
would be useful in this app of
"extensions" So therefore emphasizing on extensions is more important than
emphasizing on commands.
Which begs the question, should the project have a different name? I don't
know if we're ready to go down
that road yet.
I think the best solution at this point is django_extensions. And we can
namespace commands now or later. I
don't care. I think though that these types of disruptive changes should be
made now.
jbalonso, I can add you to the project. But regarding this issue I really want
v.oosveen since he's the one
managing the project.
Original comment by mtr...@gmail.com
on 24 Jul 2008 at 6:37
Okey,
I'll leave this open till the weekend, so people have some time to respond. (or
grab
a hold on me on the #django irc channel)
In the mean time i hope to get jbalonso's setup.py patches into svn before the
weekend.
Original comment by v.oostv...@gmail.com
on 29 Jul 2008 at 6:34
Scheduling committing the name change on 8th or 9th of August
Original comment by v.oostv...@gmail.com
on 6 Aug 2008 at 6:38
it has been done :)
Original comment by v.oostv...@gmail.com
on 15 Aug 2008 at 6:09
Original issue reported on code.google.com by
jbalo...@gmail.com
on 18 Jul 2008 at 3:23