search

liuyinz / mini-echo.el

Show buffer status in echo area , get rid of mode-line!
GNU General Public License v3.0
71 stars 6 forks source link

Add lsp-modeline integration #3

Closed Crandel closed 10 months ago

Crandel commented 10 months ago

According to lsp docs it is possible to show project errors in modeline.

Would be nice to extend already implemented lsp segment or add lsp-errors segment with same integration.

liuyinz commented 10 months ago

Does lsp-mode show diagnostics information by using flymake/flycheck frontend? I'm not familiar with lsp-mode, but it seems it's OK according to README

Crandel commented 10 months ago

I guess you can find an example here, if I correctly understand doom-modeline src code. But I could be mistaken as I have very little elisp understanding. https://github.com/seagle0128/doom-modeline/blob/master/doom-modeline-segments.el#L2032

Crandel commented 10 months ago

In modeline it just shows error/warning count like on this image https://emacs-lsp.github.io/lsp-mode/examples/modeline-diagnostics.png

liuyinz commented 10 months ago

Oh, I understand it. No, mini-echo don't implement these complicated features, maybe doom-modeline are better for you. @Crandel

liuyinz commented 10 months ago

Showing error counts is the design purpose of flymake segments, if you want to show the current error of point，please use other ways。closed。

Crandel commented 10 months ago

I finally figure out how to show lsp diagnostics errors in flymake

I need to explicitly set 

  (setq lsp-diagnostics-provider :flymake)

Now everything is working with flymake segment