Extended Themes with ComputerModern, PolarAxis, Colorbar and ratio-control

liuyxpp / MakiePublication.jl

A Julia package for producing publication quality figures based on Makie.jl.

Other

112 stars 7 forks source link

Extended Themes with ComputerModern, PolarAxis, Colorbar and ratio-control #7

Closed henrik-wolf closed 11 months ago

henrik-wolf commented 11 months ago

While writing my thesis, I extended this layout in some small ways, which might be nice to incorporate into the package. Even though this is not the best practise, this PR contains them all, as I think doing about 8 separate PRs changing only a few lines at a time would be much more complicated. Here is a list of the things I changed/added:

Removed the CairoMakie dependency, as there is no code explicitly depending on it
Added the option to set the default font to Computer Modern provided by MathTexEngine.jl with the usetexfont (for non-web layouts.)
Added the option to control the aspect ratio of the figures with the heightwidthratio keyword
added the patchcolor to the palette
reduced the default rowgap and colgap to 8
styled the PolarAxis and Colorbar to match the Axis

liuyxpp commented 11 months ago

Cool! Thank you for your contribution!

Do you have any demo PolarAxis figures and figures with newly customized color bar? Can you add such demo figures to the doc?
I explicitly add CairoMakie because this package is not meant to be used with any other Makie backend to ensure high quality of the output figure (i.e. vectorized format). What do you think?

henrik-wolf commented 11 months ago

sure. Just added a new commit with a little script. Where in the docs do you think this would belong?
Just adding CairoMakie as a dependency feels like it misses the point of saying that this package is only supposed to be used with CairoMakie. If we want to "enforce" the usage with CairoMakie, I would suggest to @reexport it. On the other hand, if we state in the docs that we did not test any other backend, why shouldn't people use this package with other backends? Even if it is meant to produce static figures for publications, there should be no problem using these themes with other backends.

liuyxpp commented 11 months ago

The example figure is great! However, I also found it is hard to present anywhere in the doc. Maybe I'll leave it for future consideration and merge the PR first. Thanks!