search

liuyxxy / pe

0 stars 0 forks source link

able to add invalid url in add patient/edit patient #1

Open liuyxxy opened 3 years ago

liuyxxy commented 3 years ago

system: catalina

description: while the UG states that only certain urls are valid, I was able to enter anything I liked.

expected and actual result: expected error message, instead patient was added. This issue occurs for edit patient as well.

step to reproduce:

  1. type in parameters as required.
  2. instead of "www." type any of the following headers in the screenshots, ie. "www," "ww." "http"
  3. for top level domain, type anything that is longer than 6 alphabets long or not an alphabet.

Screen Shot 2020-11-13 at 5.05.13 PM.png

Screen Shot 2020-11-13 at 5.00.38 PM.png

Screen Shot 2020-11-13 at 4.23.01 PM.png

Screen Shot 2020-11-13 at 5.01.51 PM.png

Screen Shot 2020-11-13 at 5.04.37 PM.png

nus-pe-bot commented 3 years ago

Team's Response

We have indicated our definition of a valid url in the UG clearly and we wanted to relax the requirements of a valid URL to account for local host (which may have unusual namings).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: UG also states the definition for a valid email and gives error messages for invalid emails; however this is not done for medical records. As a user, I would expect that invalid entries for both would give error messages.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Unlike emails which are optional, medical records are a compulsory field. As such, all users could face the issue of possibly entering an invalid url and not receiving an error message prompting them to re-enter the valid url. As MR urls are an integral part of this application, I believe it's severity should still be medium.