search

liuz888 / ethernetip4j

Automatically exported from code.google.com/p/ethernetip4j
0 stars 0 forks source link

several bug fixes and enhancements #2

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi,
please find the attached small patch that addresses the follow issues:

- Fix for fragmented read. 
Current version threats the response always as an array. That is not the case 
when you are reading the maximum object numbers that fit a single fragment + 1. 
In that case the "+1" is returned as a simple object. So check like the one 
done for normal read should be done.

- In CipCommandSpecificDataRequest.fillBuffer the parameters 
routePathLinkedAddress and routePathPort are swapped.

The patch also adds support for reading the STRING datatype using the 
SimpleLogixCommunicator class

Original issue reported on code.google.com by marco...@gmail.com on 18 Mar 2014 at 4:10

Attachments:

GoogleCodeExporter commented 9 years ago 
PATCH REMOVED, SEE ISSUE 4 FOR A CUMULATIVE PATCH OF THIS AND OTHER PROBLEMS

Original comment by marco...@gmail.com on 27 Mar 2014 at 5:14