search

liuzhe02 / bigbluebutton

Automatically exported from code.google.com/p/bigbluebutton
0 stars 0 forks source link

Audio Join from JS API doesn't respect the skipCheck option #1692

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I use the Audio skipCheck="true" and Video skipCamSettingsCheck="true" options.

When joining the meeting with Audio autoJoin="true" there is no dialogue 
regarding audio settings, just the security dialogue from Flash.

If I stop Audio, then press the Join Audio button in the toolbar I'm 
re-connected and there is no MicSettings dialogue.

However, if I close audio, then later request via JavaScript 
BBB.joinVoiceConference(); (internally swfObj.joinVoiceRequest();) there is a 
dialogue for Audio Settings (MicSettings.mxml)

It looks like the ToolBarButton::startPhone() button routine checks 
PhoneOptions but the ExternalCallback handler does not.

Original issue reported on code.google.com by david.bu...@edoceo.com on 25 Nov 2013 at 8:38

GoogleCodeExporter commented 9 years ago 
Here's a quick patch I put together, clearly not the perfect soulution but it 
get's things working properly here.  See note about a common routine, I'm 
duplicating some stuff found in ToolbarButton file.

Original comment by david.bu...@edoceo.com on 25 Nov 2013 at 10:57

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for digging into this.  Can we get a signed contributor agreement so we 
could review/merge in your patch?  See

  https://code.google.com/p/bigbluebutton/wiki/FAQ#Contributing_to_BigBlueButton

Original comment by ffdixon@gmail.com on 26 Nov 2013 at 1:05

GoogleCodeExporter commented 9 years ago

Original comment by ffdixon@gmail.com on 13 Dec 2013 at 12:22

GoogleCodeExporter commented 9 years ago

Original comment by ffdixon@gmail.com on 13 Dec 2013 at 12:24

GoogleCodeExporter commented 9 years ago

Original comment by ffdixon@gmail.com on 25 Jul 2014 at 10:08

GoogleCodeExporter commented 9 years ago

Original comment by ffdixon@gmail.com on 8 Aug 2014 at 11:37

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
After merging with branch "connect-bbb-apps-html5" in commit 
https://github.com/bigbluebutton/bigbluebutton/commit/bee1320463e063f8329b93ef82
400271e32ca513 ; this feature has been broken.

In the new implementation when autoJoin is set to true, should 
SHOW_AUDIO_SELECTION event be dispatched. Am I right ?

Another obvious question. What should be selected by default when autoJoin is 
selected, WebRTC or Flash audio ?

Original comment by ghazi.no...@gmail.com on 12 Aug 2014 at 10:14

GoogleCodeExporter commented 9 years ago 
There are actually three options

  1.  WebRTC Audio
  2.  Flash Audio
  3.  Listen Only

I think the current implementation in 0.9.0-dev auto join with Flash or Listen 
Only, as set by 

  forceListenOnly="false|true"

However, to accommodate all three choices, we should probably change this to

  autoJoinAs="webrtc|flash|listen"

to give developers the choice of choosing which method.

Original comment by ffdixon@gmail.com on 12 Aug 2014 at 10:27

GoogleCodeExporter commented 9 years ago 
Will the option forceListenOnly stay or it needs to be removed ? If it stays 
the only possible value of autoJoinsAS needs to be "listen".
Waht do you think of Fred ?

Original comment by ghazi.no...@gmail.com on 14 Aug 2014 at 5:55

GoogleCodeExporter commented 9 years ago 
fixed in
https://github.com/bigbluebutton/bigbluebutton/commit/c3b0ba13530d36ff42dedbd523
fb6ffd9289e2b4

Original comment by ritza...@gmail.com on 24 Oct 2014 at 9:32