liuzhengzhe / One-Thing-One-Click

https://arxiv.org/abs/2104.02246 One Thing One Click (CVPR 2021) https://arxiv.org/abs/2303.14727 One Thing One Click++ (Arxiv)
54 stars 8 forks source link

About spatial_shape clip #16

Closed iris0329 closed 2 years ago

iris0329 commented 2 years ago

Hi Liu,

In your config file, it has full_scale: [128, 512],

and in the trainMerge(), it has spatial_shape = np.clip((locs.max(0)[0][1:] + 1).numpy(), self.full_scale[0], None)

Could you tell me why do you need to clip the locs with the limitation of 128? Thank you~

liuzhengzhe commented 2 years ago

Thanks for your message.

We directly follow the setting in PointGroup ( https://github.com/dvlab-research/PointGroup), and did not change the parameters.

Iris @.***> 于2021年12月28日周二 11:12写道:

Hi Liu,

In your config file, it has full_scale: [128, 512],

and in the trainMerge(), it has spatial_shape = np.clip((locs.max(0)[0][1:] + 1).numpy(), self.full_scale[0], None)

Could you tell me why do you need to clip the locs with the limitation of 128? Thank you~

— Reply to this email directly, view it on GitHub https://github.com/liuzhengzhe/One-Thing-One-Click/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7WPDDD3QUB2LKGR344D23UTETJ7ANCNFSM5K3LI54A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

iris0329 commented 2 years ago

Okay, Thank you.