live-codes / livecodes

Code Playground That Just Works!
https://livecodes.io
MIT License
785 stars 66 forks source link

Bug: build/index.html not getting patched with build hash #436

Closed aehlke closed 10 months ago

aehlke commented 1 year ago

Describe the bug

From build/index.html: <script src="livecodes/{{hash:index.js}}"></script>

Other files have their hash patterns replaced properly.

Steps to reproduce

DOCS_BASE_URL=null npm run build

Affected services

Repo build/deploy

Platforms

No response

Browsers

No response

Environment

No response

Share URL(s)

No response

Configuration

No response

Additional context

No response

Is it already fixed?

None

Code of Conduct

Contributing Docs

hatemhosny commented 1 year ago

Weird!

This would cause the playground to not load at all, which would cause all e2e tests to fail. I have not had this issue, neither locally or on other environments (github actions, cloudflare pages, netlify, github pages)

Does that happen every time or is it flacky?

Any console errors?

Are you using the latest commit?

Also, if you do not want to build the docs, you should use this command instead (as stated here)

DOCS_BASE_URL=null npm run build:app
hatemhosny commented 10 months ago

I assume this is no longer a problem. I will close this for the sake of organization. Please feel free to re-open it if you still face this problem.

aehlke commented 10 months ago

I'll reopen if/when I revisit - I'm just using a fork at an old version for now but will update later and try again, thx