search

liveblocks / liveblocks

Liveblocks is the platform for adding collaborative editing, comments, and notifications into your application.
https://liveblocks.io
Apache License 2.0
3.51k stars 281 forks source link

Add a unit test for the bug uncovered by #292 #293

Closed GuillaumeSalles closed 1 year ago

GuillaumeSalles commented 2 years ago

https://github.com/liveblocks/liveblocks/pull/292#discussion_r887722211

RickyC0626 commented 1 year ago

Hey, I noticed that the .toImmutable() APIs are preferred over the legacy helper functions. Will the Redux and Zustand packages continue to use the legacy functions in the near future? If so, I'd like to work on this test.

nvie commented 1 year ago

Hey, I noticed that the .toImmutable() APIs are preferred over the legacy helper functions. Will the Redux and Zustand packages continue to use the legacy functions in the near future? If so, I'd like to work on this test.

Realistically, yes. I won't have the time to rewrite any of that soon, so you can assume that at least in the next version it will still be using the old/legacy APIs. Really appreciate the help on this! 🙏