search

livebook-dev / kino

Client-driven interactive widgets for Livebook
Apache License 2.0
361 stars 60 forks source link

Add docs related to auth when using Kino.Proxy #433

Closed hugobarauna closed 3 months ago

hugobarauna commented 3 months ago

@josevalim can I merge this?

josevalim commented 3 months ago

@hugobarauna to merge this, you should either use Plug.BasicAuth, or keep the token aprpoach, but use Plug.Crypto.secure_compare(user_token, expected_token)., Then feel free to ship it!

hugobarauna commented 3 months ago

@josevalim now it should be ready to merge. Please take a last look.