search

livebook-dev / kino_db

Database integrations for Livebook
Apache License 2.0
40 stars 16 forks source link

Prettify CSS/JS files #38

Closed kianmeng closed 2 years ago

kianmeng commented 2 years ago

Formatted via prettier -w **/*.{js,css}

jonatanklosko commented 2 years ago

Hey @kianmeng! If we relied on npm it would definitely make sense to have a formatting task, however kino_db doesn't require node at all, so I wouldn't add this check. Given that we have a relatively small amount of js/css I think that's fine.

That said, I would happily merge the formatting changes to js/css files :) Note that we don't want to format .livemd with prettier, since it's already formatted by Livebook pretty much.

kianmeng commented 2 years ago

@jonatanklosko Thanks for letting me know. I've updated the changes as requested.

kianmeng commented 2 years ago

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face: