search

livebook-dev / kino_vega_lite

Vega-Lite (graphics) integration for Livebook
Apache License 2.0
26 stars 8 forks source link

Optionally disable the livebook theme #55

Closed pnezis closed 5 months ago

pnezis commented 5 months ago

It was reported in Tucan that some themes do not render properly. After some investigation it seems that the reason is that kino_vega_lite applies a default theme, which may overwrite the Tucan themes settings based on vega-lite precedence settings.

I am not sure if this is possible, but a possible workaround would be to conditionally apply the livebook theme. For example:

KinoVegaLite.configure(apply_default_theme: false)

If this is doable, and you agree with this, I can have a look into it (even though JS is not my thing 😄 )

jonatanklosko commented 5 months ago

Hey, I think we can have Kino.VegaLite.configure(theme: nil | :livebook), with :livebook being the default. A PR is welcome!

pnezis commented 5 months ago

Sounds good, will send a PR the following days.