search

livebook-dev / livebook.dev

Landing page for Livebook
https://livebook.dev
103 stars 15 forks source link

News section overflows sponsors section on Safari #7

Closed nandofarias closed 3 years ago

nandofarias commented 3 years ago

Good day folks, fantastic work. Congrats to the whole team.

As a user of Safari, I noticed a small overflow on the news section over the fly.io logo.

Here is how it looks to me: Screen Shot 2021-10-19 at 12 08 51

This is probably related to Safari interpretation of content height (https://stackoverflow.com/a/44773109/4660005)

Changing the CSS class on https://github.com/livebook-dev/livebook_website/blob/main/src/index.html#L372 from h-full to h-auto should get the job done without any changes on the behavior for other browsers.

Thanks again for the fantastic website.

jonatanklosko commented 3 years ago

Hey, @nandofarias, thanks for all the details! Looking closer I think the h-full class was just a leftover from me trying something and we shouldn't need it in the first place. I've just removed it in f54b8a6ed18e239147ee270784436d563ef922d1, please let me know if the website looks good for you now :D

nandofarias commented 3 years ago

All good now.

Screen Shot 2021-10-19 at 12 30 07

Thanks @jonatanklosko 🎉

jonatanklosko commented 3 years ago

Perfect, thanks a lot!! :cat: