search

livebook-dev / livebook

Automate code & data workflows with interactive Elixir notebooks
https://livebook.dev
Apache License 2.0
4.99k stars 427 forks source link

Support persisting Fly runtime config in a workspace secret #2714

Closed jonatanklosko closed 4 months ago

jonatanklosko commented 4 months ago

https://github.com/user-attachments/assets/3558153c-00be-45e8-942e-2a7c4830fbe0

github-actions[bot] commented 4 months ago

Uffizzi Preview deployment-54362 was deleted.

josevalim commented 4 months ago

Quick question: What do you think about having the buttons on the bottom, on the same row as Connect but left side? And then, when you click save, you expand the contents below it, instead of swapping the whole page? Another option is to have a "Save and connect" button, that takes you to the save screen afterwards.

Plus, in the save screen, we should make it clear on which workspace we are saving it on. :)

jonatanklosko commented 4 months ago

Quick question: What do you think about having the buttons on the bottom, on the same row as Connect but left side? And then, when you click save, you expand the contents below it, instead of swapping the whole page? Another option is to have a "Save and connect" button, that takes you to the save screen afterwards.

I tried different versions and I'm not really sure. I feel that having buttons at the bottom is a bit weird because the idea is that the form is "expanding" as you enter the token and app, and the fixed buttons break that. Another option would be to have the load button as is, and show save at the bottom only once there is connect, but then they are no longer grouped. If you have a stronger preference let me know. As for "Save and connect", I would not couple these two actions.

Plus, in the save screen, we should make it clear on which workspace we are saving it on. :)

Good call, done!