livebook-dev / livebook

Automate code & data workflows with interactive Elixir notebooks
https://livebook.dev
Apache License 2.0
4.87k stars 416 forks source link

Make the go-to-definition link a client concern #2746

Closed jonatanklosko closed 1 month ago

jonatanklosko commented 1 month ago

This changes the hover details, so that instead of including a magic link in the docs (#go-to-definition?#{...}), we include the location in the intellisense response and create a link on the client, which looks like this:

image

Since the "details" request now returns the location, we can reuse it for on-click go-to-definition as well :)

Initially I was thinking of moving "View on HexDocs" there as well, but I think it's fine as is, those are distinct things.