search

livebook-dev / livebook

Automate code & data workflows with interactive Elixir notebooks
https://livebook.dev
Apache License 2.0
4.91k stars 421 forks source link

Remove LIVEBOOK_APPS_PATH_HUB_ID #2816

Closed josevalim closed 4 days ago

josevalim commented 2 weeks ago

Instead, we will build the ID from LIVEBOOK_TEAMS_AUTH.

jonatanklosko commented 2 weeks ago

Note: we want to default to personal hub id, if teams auth is not specified.

josevalim commented 2 weeks ago

The default today is nothing, no? So we don't check the hub id at all. Shouldn't we stick to that?

jonatanklosko commented 2 weeks ago

When generating the Dockerfile for airgapped deployment with personal hub we set ENV LIVEBOOK_APPS_PATH_HUB_ID "personal-hub". If we get the id from LIVEBOOK_TEAMS_AUTH, then there is no option to set it for personal hub.

josevalim commented 2 weeks ago

Right, but I am not sure we would be losing anything here. Personal-hub does not identify a particular individual, so it does not exclude you from running a third party notebook. And enforcing everything to be "personal-hub" may break some deployments. So I think it is easier and more straight-forward to say there is no filtering unless you use teams.

jonatanklosko commented 2 weeks ago

And enforcing everything to be "personal-hub" may break some deployments.

WDYM?

so it does not exclude you from running a third party notebook

It skips teams notebooks in the same directory (deploying which would fail anyway), though we still warn. So yeah, I think making it teams specific is fine :)