Code editor doesn't support my keyboard layout

[jaimeiniesta]

Environment

• Elixir & Erlang/OTP versions (elixir --version):

Erlang/OTP 23 [erts-11.2.2.1] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] [hipe] Elixir 1.12.0 (compiled with Erlang/OTP 23)

• Operating system: macOS Big Sur 11.4

• Livebook version: 0.1.2

• How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): MIX_ENV=prod mix phx.server

• Browsers that reproduce this bug (the more the merrier):

  • Chrome 91.0.4472.106
  • Safari 14.1.1 (16611.2.7.1.4)

• Spanish ISO Keyboard Layout

• Include what is logged in the browser console: nothing of interest.

• Include what is logged to the server console: nothing of interest.

Current behavior

While in Firefox 89.0 it works fine, I can't get the bracket characters like { and } in the code editor when working in Chrome or Safari. I have a Spanish ISO Keyboard layout. This seems an issue or misconfiguration with Monaco Editor.

Expected behavior

I'd like to be able to include all characters in my keyboard layout! :)

[jaimeiniesta]

Tailwind Play also uses Monaco Editor - brackets work fine there in Chrome. Repo.

[josevalim]

Thanks @jaimeiniesta! Quick question: if you are running from master, can you please share your commit?

[jaimeiniesta]

Yes, I just downloaded it today, commit is https://github.com/elixir-nx/livebook/commit/2b2d6c9d509b02d64d428f93844598168bb65e60

[jonatanklosko]

@jaimeiniesta is it the case only for Elixir cells, or for Markdown cells as well? Also, does it work on the Monaco homepage?

[jaimeiniesta]

@jonatanklosko it happens both on Elixir and Mardown cells.

It works fine on the editor in Monaco homepage, and on Tailwind Play.

[jonatanklosko]

There's a recent issue that looks relevant (https://github.com/microsoft/monaco-editor/issues/2533) and it a has been addressed in monaco 0.25.2. I've just updated to this version in e49aaa62d2250f837ffd4b8b5ed582621377bcfb, please let me know if this helps :)

[jaimeiniesta]

Yay! It works great now, thanks!

Verified in Chrome, Safari and Firefox.

[jonatanklosko]

Thanks for verifying! :cat: