Adds LiveCode Builder linter

livecode / atom-language-livecode

LiveCode Language package for Atom

GNU General Public License v3.0

16 stars 15 forks source link

Adds LiveCode Builder linter #12

Closed montegoulding closed 8 years ago

montegoulding commented 8 years ago

This commit adds support for source.lcb to be linted using lc-compile. It adds two new settings:

The path for lc-compile
The module paths delimited by ;

Default settings assume a debug build of the livened repo in the home directory.

montegoulding commented 8 years ago

I've got another PR coming that merges iRev into LiveCode Script, does injection of the syntax into any text file with <?lc ?> blocks in it and also fixes a few minor issues but as the loss of the iRev scope impacts the linter script I'd rather base it on this rather than fork off master in its current state and send a PR that will have merge conflicts with this. Do you see any issues with that?

peter-b commented 8 years ago

No, that sounds fine.

Just having a look through this pull request:

Is there any reason not to default to looking in the livecode/$PLATFORM-bin/ directories rather than the build directories? I would prefer the former if possible. Heck, why not just default to expecting the tools to be in the $PATH?
Style-wise, I commend to you the merits of vertical whitespace :wink:

I'm happy for you to go ahead and merge this, whether or not you change the default bin path.

montegoulding commented 8 years ago

I have no livecode/$PLATFORM-bin/ in my repo or do you mean inside a LC distribution? I considered defaulting to lc-compile being on $PATH at first but then the module paths probably need more explanation. Would be handy if the LC installer installed command line tools and perhaps a $LIVECODE_MODULE_PATH environment variable for the core modules.