search

livecode / atom-language-livecode

LiveCode Language package for Atom
GNU General Public License v3.0
16 stars 15 forks source link

Refactor to merge LiveCode Script and iRev #13

Closed montegoulding closed 8 years ago

montegoulding commented 8 years ago

The linter now detects server scripts by looking for the opening tag in the script. This change enables us to use the same set of generated autocomplete snippets without duplicating them. It also makes maintenance easier by reducing grammar duplication.

Review on Reviewable

montegoulding commented 8 years ago

Er... hold the phone on this as it breaks other grammars. I just checked php. I'll see what I can come up with but I have a lot on right now so perhaps target this at 0.7 release so it doesn't hold things up.

montegoulding commented 8 years ago

Hmm... whitespace diffs. Atom strips all the trailing whitespace from files you touch sorry. I'll investigate the merge conflict

montegoulding commented 8 years ago

Sorry, it was a whitespace issue on a spot where I've been testing the linter. Should merge cleanly now.

peter-b commented 8 years ago

This looks good, thanks.