search

livecode / atom-language-livecode

LiveCode Language package for Atom
GNU General Public License v3.0
16 stars 15 forks source link

Fixes for issues 16 & 18 #20

Closed montegoulding closed 8 years ago

montegoulding commented 8 years ago

Review on Reviewable

peter-b commented 8 years ago

@montegoulding Thank you so much for looking into this so promptly!

montegoulding commented 8 years ago

This latest commit adds support for:

if condition then something1 else something2

It also adds support for the following with a quirk on the else. Atom seems to decrease the indent when it hits a match but doesn't increase it again when it no longer matches. This means when you are typing else it will step back at the end of the word and if you keep typing it stays at the wrong indent instead of popping back as it should. Using the menu to reset the indents does fix it though. I guess this is reportable on Atom...

if condition
then something1
else something2
peter-b commented 8 years ago

@montegoulding I'm really sorry, but all the contents of your last comment should be in the commit message. Can you git commit --amend it, please? It's so important to have commit messages that accurately reflect the contents of the diff.

montegoulding commented 8 years ago

OK, force pushing to a branch that mid PR worked better than I expected ;-)

peter-b commented 8 years ago

@montegoulding Thanks for that. On Monday I'll try and reorganise the docs a bit to make it a little clearer, and then do a 0.6.1.