search

livecomsjournal / livecomsjournal.github.io

Content for policy/instructional pages of the Living Journal of Computational Molecular Science (LiveCoMS)
https://livecomsjournal.github.io
6 stars 15 forks source link

Linking contributor license on the webpage? #164

Closed mrshirts closed 5 years ago

mrshirts commented 5 years ago

We need to link the contributor license to the author instructions. Right now, it doesn't appear to actually be linked anywhere. But I'm not sure how to link it with the MarkDown setup. Any suggestion? I could link directly to the GitHub, but it seems like there should be some direct link.

On GitHub, its at: https://github.com/livecomsjournal/livecomsjournal.github.io/blob/master/_author_instructions/LiveCoMS_contributor_license.pdf

dmzuckerman commented 5 years ago

One comment on the form itself. Do we really want faxes or regular mails? Seems like we should require email or upload if that's possible.

And I'm not clear why you can't make a regular link with markdown ... won't that just download the pdf??

mrshirts commented 5 years ago

I will fix it so that email is preferred.

And I'm not clear why you can't make a regular link with markdown ... won't that just download the pdf??

The problem is that the paths get changed by jekyll. Not sure how. Specifically, although the license is at: https://github.com/livecomsjournal/livecomsjournal.github.io/blob/master/_author_instructions/LiveCoMS_contributor_license.pdf,

https://livecomsjournal.github.io/_author_instructions/LiveCoMS_contributor_license.pdf is not a

valid location. Neither is:

https://livecomsjournal.github.io/authors/LiveCoMS_contributor_license.pdf

Although /authors/ is what /_author_instructions gets rewritten to.

dmzuckerman commented 5 years ago

Ask Melanie?

mrshirts commented 5 years ago

I was hoping @archgirl would see the post here :)

m2creates commented 5 years ago

We should be able to create an assets/pdf folder and then use a direct link to https://livecomsjournal.github.io/assets/pdf/LiveCoMS_contributor_license.pdf as a valid link without all the extra /blob/ stuff.

Shall I run a local test? :D

mrshirts commented 5 years ago

Works for me!

On Tue, Oct 2, 2018 at 11:14 AM Melanie E Magdalena < notifications@github.com> wrote:

We should be able to create an assets/pdf folder and then use a direct link to https://livecomsjournal.github.io/assets/pdf/LiveCoMS_contributor_license.pdf as a valid link without all the extra /blob/ stuff.

Shall I run a local test? :D

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/livecomsjournal/livecomsjournal.github.io/issues/164#issuecomment-426356163, or mute the thread https://github.com/notifications/unsubscribe-auth/AEE31F8g99Ph0y3qNrGJZuZdR3a6diY3ks5ug58CgaJpZM4XBWNg .

m2creates commented 5 years ago

Great news! It seems to be working like a charm. Here's a quick Loom about how the change works, which I'm sticking on the PR notes as well!