search

liveh2o / active_remote

Active Remote provides Active Record-like object-relational mapping over RPC. It's Active Record for your platform.
MIT License
63 stars 23 forks source link

Add granular protobuf errors for ActiveRemote #58

Closed ryanbjones closed 7 years ago

ryanbjones commented 7 years ago

From https://github.com/liveh2o/active_remote/issues/39

Example set of errors https://github.com/ruby-protobuf/protobuf/blob/master/lib/protobuf/rpc/error/client_error.rb

This will make it so we bubble up the type of error given from Protobuf

@liveh2o @abrandoned @mmmries

jgaxn commented 7 years ago

LGTM :shipit:

mmmries commented 7 years ago

:shipit: nice call on making all of the granular error inherit from ActiveRemoteError so all the existing catch clauses that people are using will still work.