search

liveh2o / active_remote

Active Remote provides Active Record-like object-relational mapping over RPC. It's Active Record for your platform.
MIT License
63 stars 23 forks source link

added ruby-3.1 compatibility #97

Closed skunkworker closed 3 months ago

skunkworker commented 3 months ago

Specs work on:

Jruby 9.3/9.4 CRuby 2.7/3.0/3.1

after the arguments change.

skunkworker commented 3 months ago

I'll get multiple rails support testing up soon.

liveh2o commented 3 months ago

Released in v7.0.0.

liveh2o commented 3 months ago

I'm guessing merging this and #96 changed something because actions are now failing... 🤔

skunkworker commented 3 months ago

@liveh2o I think we need to make a separate 6-1-stable branch with includes Ruby 3.1 support. As the newest Rails 7 release is pinned pessimistically to ~> 7.0. And I am currently in the process of taking a Rails 6.1 app to JRuby-9.4 (3.1 syntax) and there is no version that supports that at this time.

liveh2o commented 3 months ago

@liveh2o I think we need to make a separate 6-1-stable branch with includes Ruby 3.1 support. As the newest Rails 7 release is pinned pessimistically to ~> 7.0. And I am currently in the process of taking a Rails 6.1 app to JRuby-9.4 (3.1 syntax) and there is no version that supports that at this time.

Ah, I see. I backported this change to v6.1.2. Specs pass under Ruby 2.7, so we should be good to go. Let me know if you have issues.

liveh2o commented 3 months ago

I also backported this change to v6.0.3 even though Rails 6.0 is EOL.