search

livehelpnow / tds_ecto

TDS Adapter for Ecto
57 stars 34 forks source link

Small typo in errorcodes.txt #73

Open tasosval opened 5 years ago

tasosval commented 5 years ago

Hello,

we came up to an unexpected error while testing inserting duplicate rows in a db table with UNIQUE KEY constraint

The problem was traced to the errorcodes.txt and specifically the first line which is currently: unique,2627,Violation of UNIQUE KEY constraint '%.ls'..

While it should be unique,2627,Violation of UNIQUE KEY constraint '(\S+?)'..*

as all the other lines are. This should be some sort typo, which I have seen has also been transferred to the TDS project.

mjaric commented 5 years ago

Hi @tasosval

Good finding, thanks! I missed to replace that somehow.

For now it should be in both repos. First I added it to tds_ecto and later introduced same thing in tds so I can migrate it there at some major version release. And hopefully make tds error labels similar to one that are in postgrex for some other ecto integration reasons.

Would you create PR for this repo?

Thank you

tasosval commented 5 years ago

Sure thing. I will cook something up in the next couple of days. Thx for the immediate response

tasosval commented 5 years ago

I have created a PR for this. Is there anything else I can do to help you resolve this?