livekit / agents-js

Build realtime multimodal AI agents with Node.js
https://docs.livekit.io/agents
Apache License 2.0
113 stars 12 forks source link

Fix the done property on Future #83

Closed bcherry closed 3 weeks ago

bcherry commented 3 weeks ago

I added this in a recent PR but overlooked how Future actually works, which overrides the default implementations of resolve and reject with the promise instead of extending them, so the changes were overwritten. This change fixes it so that the promise methods merely extend the future's resolve/reject and done now works as intended.

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 9595d60670e310b176cac0c69e8d05523e8b341d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ----------------------------- | ----- | | @livekit/agents | Patch | | @livekit/agents-plugin-openai | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR