livekit / client-sdk-android

LiveKit SDK for Android
https://docs.livekit.io
Apache License 2.0
160 stars 63 forks source link

ConcurrentModificationException of RemoteVideoTrack. #401

Closed jinnyuri closed 2 months ago

jinnyuri commented 3 months ago

Describe the bug Sometime ConcurrentModificationException occurs, if multiple people exit a group call at the same time. I apologize for the lack of detailed logs, but describe solution below.

To Reproduce Steps to reproduce the behavior:

  1. Make a group call.
  2. Exit at same time.

Expected behavior Exception not occurs.

Screenshots If applicable, add screenshots to help explain your problem.

Device Info:

Additional context Same as VideoTrack, if we apply lock for sinkVisibilityMap of RemoteVideoTrack, we can avoid the exception.

davidliu commented 3 months ago

Whoops, forgot to lock this down when I did the video track changes. Thanks for filing the issue.