search

livekit / client-sdk-android

LiveKit SDK for Android
https://docs.livekit.io
Apache License 2.0
173 stars 68 forks source link

consider changing EventListenable.collect to return Nothing #457

Closed weefbellington closed 1 month ago

weefbellington commented 1 month ago

SharedFlow.collect function specifies Nothing as its return type. This is helpful for preventing errors, since the linter can mark any code after collect as unreachable.

Consider changing the EventListenable.collect extension function to match.

See also this issue: https://github.com/Kotlin/kotlinx.coroutines/issues/2789

davidliu commented 1 month ago

Thanks for the heads up! Will do.