livekit / client-sdk-js

LiveKit browser client SDK (javascript)
https://livekit.io
Apache License 2.0
368 stars 149 forks source link

Allow simulcast together with E2EE for supported Safari versions #1117

Closed lukasIO closed 6 months ago

lukasIO commented 6 months ago

closes #1113

Chrome on iOS got reported as Chrome by our browser parser even though it runs WebKit under the hood. So we failed to detect that we actually have to disable simulcast for Chrome on iOS.

Additionally to catching iOS browser in general, it makes sense to re-evaluate whether the restriction (simulcast + E2EE) is still not working in recent Safari versions. For iOS it will be tricky to differentiate that based on browser version though as we'll need to get insight on the actual Safari version rather than the Firefox/Chrome version.

edit:

found the related webkit bug https://bugs.webkit.org/show_bug.cgi?id=257803. The fix got released as part of Safari v17.2, so everything beyond that should be fine. Added iOS version parsing in order to determine the underlying Safari version on chrome and firefox iOS.

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: ba63212eccef8736bc61b4d5dc3e09ead2c14f7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | livekit-client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 6 months ago

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 79.04 KB (+0.21% 🔺)
dist/livekit-client.umd.js 84.66 KB (+0.19% 🔺)