Make sure setting a new processor doesn't remove the processor html element

livekit / client-sdk-js

LiveKit browser client SDK (javascript)

https://livekit.io

Apache License 2.0

334 stars 143 forks source link

Make sure setting a new processor doesn't remove the processor html element #1149

Closed lukasIO closed 3 months ago

lukasIO commented 3 months ago

Previously, when a new processor was being set, we would re-use the processor element if possible. However, subsequently, we called stopProcessor which in turn then removed that element from the DOM.

This PR keeps the element around as a local variable and assigns it to this.processorElement only after the old processor has been stopped.

also closes #1148

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: a8882fbb6fa5ecfcaf00fb6c4e9cea48b6b4e34f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | livekit-client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

size-limit report 📦

Path	Size
dist/livekit-client.esm.mjs	80.06 KB (+0.02% 🔺)
dist/livekit-client.umd.js	85.8 KB (+0.04% 🔺)