search

livekit / client-sdk-js

LiveKit browser client SDK (javascript)
https://livekit.io
Apache License 2.0
334 stars 143 forks source link

Disable webAudioMix by default #1159

Closed lukasIO closed 2 months ago

lukasIO commented 2 months ago

Due to various issues around echo cancellation and sound duplication that have popped up recently, we're going to disable webAudioMix by default. The advantages of dealing with native HTMLAudioElement playback outweigh the benefits of piping everything through webAudio. The main remaining downside of webAudioMix: false is backgrounded tabs in Safari not playing back newly created audio elements if you're not also publishing yourself. That is an edge case that we'll try to fix separately, but for most users it seems better to have web audio disabled by default.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 8dc46ca06eb2697605de6181c748d2c8dc960e34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | livekit-client | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 80.2 KB (+0.01% 🔺)
dist/livekit-client.umd.js 85.99 KB (+0.01% 🔺)