Fix normalising of default device Ids in DeviceManager

livekit / client-sdk-js

LiveKit browser client SDK (javascript)

https://livekit.io

Apache License 2.0

334 stars 143 forks source link

Fix normalising of default device Ids in DeviceManager #1162

Closed lukasIO closed 2 months ago

lukasIO commented 2 months ago

and add some tests

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 053c8ef0fc549dd5312dee0441695d628e77def0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | livekit-client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

size-limit report 📦

Path	Size
dist/livekit-client.esm.mjs	80.19 KB (-0.02% 🔽)
dist/livekit-client.umd.js	85.97 KB (-0.03% 🔽)

lukasIO commented 2 months ago

yeah, agree in general. However we currently only normalize anyways for webAudioMix: true. Setting default on an AudioContext throws an error, so we are somewhat forced to normalize it in that case.