livekit / client-sdk-js

LiveKit browser client SDK (javascript)
https://livekit.io
Apache License 2.0
335 stars 146 forks source link

Only retry other regions if connection attempt has not been cancelled #1205

Closed lukasIO closed 1 month ago

lukasIO commented 1 month ago

With https://github.com/livekit/client-sdk-js/pull/1201 the initial population of the region settings got sped up. This surfaced an issue where, when given enough time for the region settings to be populated, cancelling a room connection would still trigger the region url provider internally to attempt a connection with a different region.

We were missing a check before to see whether or not the connection had been cancelled by the user before.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 0217296735b66e93649c5296fdbea76768c36282

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | livekit-client | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 80.91 KB (+0.02% 🔺)
dist/livekit-client.umd.js 86.83 KB (+0.02% 🔺)