Closed creativecbr closed 10 months ago
I can't sign CLA. Although I have added an email address to my GitHub account, I suspect that the error may have occurred because I pushed a commit without configuring the git user.email. How can I rectify this situation?
Feel free to decline this pull request. I can resend it once I've configured Git properly. Alternatively, you can expedite the process by signing the CLA on my behalf. You have my approve.
Hey. I think I had an option to include current app, but I will take a look !
Hello everyone, my issue revolves around the inability to share app content during screen sharing. I attempted to use MacOSScreenCapturer.sources with the parameter includeCurrentApplication set to true, but unfortunately, it did not yield the desired outcome.
In order to address this issue, I made the following pull request (PR) changes. In these changes, I introduced the includeCurrentApplication parameter to ScreenShareCaptureOptions and utilized it to exclude the app filter in MacOSScreenCapturer. This modification enables the retrieval of sources as demonstrated in the following code snippet:
This solution consistently works and provides a convenient resolution. If there is a misunderstanding on my part, and the issue can be resolved without these changes, please reach out to me and provide an explanation.
Thank you in advance!