livekit / client-sdk-swift

LiveKit Swift Client SDK. Easily build live audio or video experiences into your mobile app, game or website.
https://livekit.io
Apache License 2.0
176 stars 85 forks source link

Relaunch screenshare ext. when re-enabling the track #424

Closed hiroshihorie closed 1 week ago

hiroshihorie commented 1 week ago

Unless unpublished, the screenshare ext was not re-launching when calling setScreenShare(enabled: true) in iOS causing confusion.

Related issues: https://github.com/livekit/client-sdk-swift/issues/412 https://github.com/livekit-examples/swift-example/issues/37 https://github.com/livekit-examples/swift-example/issues/39

davidliu commented 1 week ago

On the other platforms, the screenshare track is unpublished entirely on disable, maybe we should do that to align the behavior?

hiroshihorie commented 1 week ago

Either way would work but I should also align MacOS screen capturing also in that case.

hiroshihorie commented 1 week ago

I think i'll just unpublish it 👍