search

livekit / components-js

Official open source React components and examples for building with LiveKit.
https://livekit.io
Apache License 2.0
149 stars 64 forks source link

Fix audio playing issue #834

Closed rnakano closed 4 months ago

rnakano commented 4 months ago

It appears that there is a bug where the audio from <AudioTrack> is not playing during <VideoConference> in v2.1.0 and v2.1.1. This likely involves the same issue as with the <VideoTrack> described in https://github.com/livekit/components-js/pull/831, where the refs aren't being passed correctly. I have made the necessary corrections on the AudioTrack side.

Related slack threads: https://livekit-users.slack.com/archives/C01KVTJH6BX/p1713514083336509

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 4116bae03ada0d2280865ec0899c0141695ed2aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | --------------------------------- | ----- | | @livekit/components-react | Patch | | @livekit/component-example-next | Patch | | @livekit/components-js-docs | Patch | | @livekit/component-docs-storybook | Patch | | @livekit/components-docs-gen | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lukasIO commented 4 months ago

Sorry, only saw this right after I just merged https://github.com/livekit/components-js/pull/835. Thanks a lot for the report and fix!

rnakano commented 4 months ago

No problem, thanks for the quick response!