livekit / components-js

Official open source React components and examples for building with LiveKit.
https://livekit.io
Apache License 2.0
149 stars 64 forks source link

Fix duplicated incoming audio when using AudioTrack renderer and its muted property #855

Closed lukasIO closed 3 months ago

lukasIO commented 3 months ago

closes https://github.com/livekit/components-js/issues/845

With webAudioMix enabled by default, we're relying on the fact that the HTMLAudioElement stays muted in the DOM as the audio playback itself will be happening through the WebAudio API.

However, we didn't extract the muted property from the AudioTrackProps before re-assigning them to the <AudioTrack /> component. This could lead to the audio being played back both through the HTMLAudioElement and the WebAudio API.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: f3c44a38110f2a12df2fa11cbfa6d8059d3b9f54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | --------------------------------- | ----- | | @livekit/components-react | Patch | | @livekit/component-example-next | Patch | | @livekit/components-js-docs | Patch | | @livekit/component-docs-storybook | Patch | | @livekit/components-docs-gen | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size
LiveKitRoom only 1.87 KB (0%)
LiveKitRoom with VideoConference 28.12 KB (+0.03% 🔺)
All exports 33.23 KB (-0.08% 🔽)