livekit / components-js

Official open source React components and examples for building with LiveKit.
Apache License 2.0
140 stars 62 forks source link

Support passing room to useIsEncrypted #871

Closed renekliment closed 1 month ago

renekliment commented 1 month ago

I am aware this is alpha, so I am not sure how much support this gets.

I would find it useful if the hook could also get the room passed directly as other hooks so it can be used in a place where Room is manually created, where the room context is not available. :pray:

I was not sure whether the hook should only get options where both participant and room could be. I can rewrite it to that if that makes more sense. :pray:

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 7135493c3030731b72b8e03c51212070c178d27e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | --------------------------------- | ----- | | @livekit/components-react | Patch | | @livekit/component-example-next | Patch | | @livekit/components-js-docs | Patch | | @livekit/component-docs-storybook | Patch | | @livekit/components-docs-gen | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

lukasIO commented 1 month ago

this makes sense, thanks for your contribution!