[BUG] mpegts no PTS found at end of file, duration not set

SijmenHuizenga commented 1 year ago

Describe the bug Some (not all) .ts files created by egress have no Presentation timestamp (PTS) set.

Egress Version We are use Livekit Cloud. This bug was observed with a recording of 2023-11-07 15:44:21:624 UTC.

Behavior I'm attaching 2 .ts files from the same egress recording.

testbed_20231107154421624.ts -> no PTS found at end of file, duration not set
testbed_20231107154427624.ts -> no errors, everything in order

I would expect all files to be timestamped in the same way. If this is expected, could you maybe explain why we're seeing this?

Additional context

This recording was made in cloud project p_2u70izoj75h egresses EG_hzVc5XuBuwp7.

frostbyte73 commented 1 year ago

Looks like there was some packet loss surrounding that segment. Does this break the playlist?

SijmenHuizenga commented 1 year ago

~Yes, this breaks playback using video.js and hls.js. The video gets stuck into an endless buffer state.~

Edit: Sorry, i confused this issue with #531. I don't know if it breaks the playlist. Because I tested this issue together with #531. I can try testing this again now.

SijmenHuizenga commented 1 year ago

After some more testing it seems that this specific error does not stop video.js from replaying the video.

livekit / egress

[BUG] mpegts no PTS found at end of file, duration not set #530