livekit / ingress

Ingest streams (RTMP/WHIP) or files (HLS, MP4) to LiveKit WebRTC
Apache License 2.0
64 stars 22 forks source link

Do not use sample providers in the go SDK #212

Closed biglittlebigben closed 5 months ago

biglittlebigben commented 5 months ago

Caling WriteSample directly on the local track makes dealing with disconnections and A/V sync easier.

WriteSample succeeds even if the PeerConnection is disconnected. This means that the output lost packet count gathered by the service is inaccurate.

Sean-Der commented 5 months ago

LGTM!

It might be worth adding easier RTCP sending in the GoSDK (I can do that)