livekit / ingress

Ingest streams (RTMP/WHIP) or files (HLS, MP4) to LiveKit WebRTC
Apache License 2.0
76 stars 26 forks source link

Trickle ICE Support for WHIP #236

Open cscherban opened 7 months ago

cscherban commented 7 months ago

Right now WHIP returns a 405 for HTTP Patch requests with Trickle ICE Candidates, as per https://www.ietf.org/archive/id/draft-ietf-wish-whip-01.html#name-ice-and-nat-support.

It would be amazing if we could remove the TODO in the code for implementing Trickle ICE and ICE Restarts. I would love guidance on how to implement it, but I don't know where to start.

biglittlebigben commented 5 months ago

Could you comment on the use case for trickle ICE, considering ingress is meant to be hosted with a public IP and media is only flowing from the client to ingress?

Regarding ICE restarts, we should indeed implement it. I was trying to get a list of several clients supporting it before doing so in order to make sure we implement it in a compatible way. OBS doesn't support ICE restarts. Do you have a favorite client we can use to test it?