livekit / ingress

Ingest streams (RTMP/WHIP) or files (HLS, MP4) to LiveKit WebRTC
Apache License 2.0
81 stars 28 forks source link

Add WHIP ICE Restart Support #267

Closed Sean-Der closed 6 months ago

Sean-Der commented 6 months ago

Marking as draft. Should be tested against a client before worth reviewing

Sean-Der commented 6 months ago

Thanks for the review @biglittlebigben I will fix that up now!

Here is a jsfiddle of how I was testing https://jsfiddle.net/phn51xz9/

Sean-Der commented 6 months ago

Ok I feel pretty good about that @biglittlebigben

Testing with clients should happen Tuesday/Wednesday!

biglittlebigben commented 6 months ago

Please let me know when you happy with your testing and this is ready to merge.

Sean-Der commented 6 months ago

@biglittlebigben testing went well, this is good for merge. I had to make one additional change though.

We now close the session when goes to failed (30 seconds of no activity) instead of disconnected (5 seconds of no activity)

The client side is waiting for 'disconnected'.