livekit / ingress

Ingest streams (RTMP/WHIP) or files (HLS, MP4) to LiveKit WebRTC
Apache License 2.0
71 stars 25 forks source link

Fix: check output, if output is nil then ignore. #62

Open jinleileiking opened 1 year ago

jinleileiking commented 1 year ago

This will cause panic later.

https://github.com/livekit/ingress/blob/a7b821a5324e1964b4bed7f524470be31b90ca00/pkg/media/webrtc.go#L167

biglittlebigben commented 1 year ago

You are right that we should handle this returned error. I'm however not sure whether we should fail the whole ingress instead of skipping the filling output. In which case did you see the NewVideoOutput failing?

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.