Closed rektdeckard closed 6 hours ago
@dennwc @davidzhao Ready for final review, I think. Couple things to note:
The Linux install script and the brew formula both rely on GitHub release artifacts, so they will come in a separate PR here and against homebrew, respectively, after this is merged and released.
Since our only means of distribution for Windows is pre-built binaries, I haven't done anything besides change the name of the binary we build. Those users will probably figure it out for themselves when they upgrade (though we might want to consider packaging for choco
and/or winget
).
And of course, all of this should line up with https://github.com/livekit/web/pull/238
livekit-cli
tolk
LK-3475curl -sSL https://get.livekit.io/cli | bash
) must wait for GitHub releasebrew install livekit-cli
)brew bump-formula-pr livekit-cli
livekit-cli
->lk
on install, and prints a deprecation warning message if the binary detects$0
is notlk
urfave/cli/v3
LK-3479Do not merge before https://github.com/livekit/web/pull/238