livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
50 stars 59 forks source link

sysctl support for arm64 #21

Closed JacobSteelsmith closed 2 years ago

JacobSteelsmith commented 2 years ago

Thanks for an awesome implementation. I'm deploying this on AWS graviton instances using EKS and Helm. Everything is working well except the sysctl service isn't starting. It's getting an exec format error which I'm presuming is due to the image not being compatible with arm64. I was wondering if anyone has found a workaround.

davidzhao commented 2 years ago

It'd be great to figure out how to run this on arm64! We do publish livekit-server in both arm64 and amd64. Maybe it's an issue with the helm chart not pulling in the right version?

Can you elaborate more on sysctl service isn't starting?

JacobSteelsmith commented 2 years ago

Thanks for the reply. When I look at the deployed pods, the livekit-server pod is up and running just fine. The pod livekit-server-sysctl has a status of "CrashLoopBackoff" and the logs for the pd show: standard_init_linux.go:228: exec user process caused: exec format error.

The helm template daemonset.yaml shows it's deploying the image gcr.io/google-containers/startup-script:v2 . It appears that image is very old and possibly retired. I see a few startup-scripts that are newer and arm64 supported such as: https://hub.docker.com/r/cilium/startup-script . This one does reference the retired script that appears to do what livekit-server-sysctl does.

This issue may be more appropriate in the livekit-helm project. My apologies if it should have gone there. I'm thinking I may be able to create a new issue in that project and see if I can learn how to edit the helm templates and see if I can get it working with this updated image, and then send a merge request.

davidzhao commented 2 years ago

@JacobSteelsmith thank you for the additional color. That makes a lot of sense. I didn't realize how old the sysctl image was; it definitely makes sense to upgrade to a newer, arm64-compatible one. If you manage to find a replacement, it would be great if you wanna submit a PR!

Moving this to the helm repo