search

livekit / livekit-helm

LiveKit Helm charts
https://docs.livekit.io
Apache License 2.0
50 stars 59 forks source link

Helm chart does not support TURN external_tls option #26

Closed bekriebel closed 2 years ago

bekriebel commented 2 years ago

Several spots in the helm chart expect to handle TLS if TURN is enabled and a tls_port is passed.

For example:

{{- if and .Values.livekit.turn.enabled .Values.livekit.turn.tls_port }}
      volumes:
        - name: lkturncert
          secret:
            secretName: {{ required "tls secret required if turn enabled" .Values.livekit.turn.secretName }}
      {{- end }}

causes the chart to fail if trying to use external_tls.

Suggested fix: Add a check for .Values.livekit.turn.external_tls and skip managing certs/TLS with the chart for cases where the load balancer is managed outside of the chart and TLS is terminated there.